Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added change password feature #1439

Closed
wants to merge 2 commits into from
Closed

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Oct 5, 2024

PR Fixes:

  • Added change password directly from app.100xdevs.com while maintaining password synchronization with harkirat.classx.co.in

Assumption env variable
APPX_AUTH_KEY = appxapi
APPX_CLIENT_SERVICE = Appx

UI /password
change Password Page

Resolves

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@atul24112001
Copy link

atul24112001 commented Oct 6, 2024

Hey, I have created the same pr But it got closed by maintainers the only difference is mine works on OTP not in current password.
#1415

@AuenKr
Copy link
Contributor Author

AuenKr commented Oct 6, 2024

@devsargam ,
Earlier I also created PR for the same feature #749 .
That was not matching the current UI, so created a new one that does not have conflicts.

@devsargam
Copy link
Collaborator

@hkirat thoughts on this? else closing this pr within a week

@AuenKr
Copy link
Contributor Author

AuenKr commented Oct 12, 2024

@devsargam @hkirat, I just want to know why it was closed previously.

previous reason:

  1. The password is not in sync with appx.
  2. Appx does not expose any endpoint for that.

as both reasons are resolved, is there any other reason for not changing the password directly from cms instead of using the appx site?

@devsargam
Copy link
Collaborator

This probably is not available from server side if I am not wrong but I will get to kirat regarding it

@devsargam devsargam closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants